This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] ioemu-remote&ioemu: support PCI Express Capabili

To: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] ioemu-remote&ioemu: support PCI Express Capability Structure version 1.
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 3 Sep 2008 11:27:52 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 03 Sep 2008 03:28:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080903170618.50EA.SHIMADA-YXB@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <20080903170618.50EA.SHIMADA-YXB@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Yuji Shimada writes ("[Xen-devel] [PATCH] ioemu-remote&ioemu: support PCI 
Express Capability Structure version 1."):
> This patch adds supporting PCI Express Capability Structure version 1
> to ioemu-remote and ioemu.

I have applied this.  But I did notice that ...

> diff --git a/hw/pass-through.c b/hw/pass-through.c
> diff --git a/hw/pass-through.c b/hw/pass-through.c

... there are two separate patches for the same file here.

I don't know how you created that patch but this is a bad idea.
patch(1) deals badly with such input and it makes it easy to
accidentally drop hunks if the person applying the patch has to fix up
minor conflicts.

As it happens the first of those two patches was already in my tree
but not yet pushed (sorry) so no harm done.


Xen-devel mailing list