This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] constify microcode hypercall argument

To: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] constify microcode hypercall argument
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Fri, 29 Aug 2008 15:28:23 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 29 Aug 2008 07:27:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200808291555.03806.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <48B808A4.76E4.0078.0@xxxxxxxxxx> <200808291555.03806.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Christoph Egger <Christoph.Egger@xxxxxxx> 29.08.08 15:55 >>>
>On Friday 29 August 2008 14:33:08 Jan Beulich wrote:
>> Linux 2.6.27 marks the data pointer in its firmware struct 'const', and
>> hence, to avoid a compiler warning, Xen's microcode update interface
>> should be properly properly constified too.
>What makes you confident, that this reason applies to other operating systems
>(Solaris, BSD) , too ?

Adding 'const' on the consumer side is always safe, as long as the consumer
guarantees it won't violate the promise. The consumer here is Xen, so
there are no worries about individual guest OSes.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>