This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-ia64-devel] Re: [Xen-devel] [PATCH] ioemu-remote: fix cross com

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] Re: [Xen-devel] [PATCH] ioemu-remote: fix cross compilation.
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Fri, 29 Aug 2008 11:36:04 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 28 Aug 2008 19:36:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18614.47275.99751.183657@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080825053105.GA28587%yamahata@xxxxxxxxxxxxx> <18614.47275.99751.183657@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6i
On Thu, Aug 28, 2008 at 03:39:39PM +0100, Ian Jackson wrote:
> Isaku Yamahata writes ("[Xen-devel] [PATCH] ioemu-remote: fix cross 
> compilation."):
> > When cross compile, INSTALL is set to cross-install by --install
> > configure option.
> >
> > However it is overwritten by including $(XEN_ROOT)/tools/Rules.mk
> > so that install command fails to strip as follows.
> > So after the include set INSTALL again when --install is passed
> > to configure.
> I think this is quite ugly really.  We're engaging in a war of
> makefiles.  Why can't Rules.mk set the right version of install ?
> Ian.

Yes, it's ugly. How about the followings? Which do you prefer?
One candidate is to modify ioemu-remote/Makefile, Makefile.target,
another is for the xen-unstable. Making INSTALL overridable
isn't intuit...

qemu-dm and qemu-dm-xen are the only commands in the xen source tree
which is installed with strip option, "-s".
The issue isn't which install command is used, but which strip
command is invoked by the install command.
GCC knows where commands are stored, however the install command
doesn't. tools/cross-install is a simple wrapper shell script to
set up PATH for the install command to find the correct strip command
by adding a directory in front of PATH.
Modifying PATH in tools/Makefile doesn't work because the install
command is invoked via shell which resets PATH.

diff --git a/Makefile b/Makefile
index bebd244..b055b3f 100644
--- a/Makefile
+++ b/Makefile
@@ -205,7 +205,7 @@ endif
 install: all $(if $(BUILD_DOCS),install-doc)
        mkdir -p "$(DESTDIR)$(bindir)"
 ifneq ($(TOOLS),)
-       $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
+       $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
        mkdir -p "$(DESTDIR)$(datadir)"
        set -e; for x in bios.bin vgabios.bin vgabios-cirrus.bin ppc_rom.bin \
diff --git a/Makefile.target b/Makefile.target
index 1aace9c..e796d61 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -707,7 +707,7 @@ clean:
 install: all install-hook
 ifneq ($(PROGS),)
-       $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
+       $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
 # Include automatically generated dependency files


diff -r 7f653c6ce545 config/StdGNU.mk
--- a/config/StdGNU.mk  Mon Aug 25 12:37:36 2008 +0900
+++ b/config/StdGNU.mk  Fri Aug 29 11:12:41 2008 +0900
@@ -16,7 +16,7 @@
 # Allow git to be wrappered in the environment
 GIT        ?= git
-INSTALL      = install
+INSTALL      ?= install
 INSTALL_DIR  = $(INSTALL) -d -m0755 -p
 INSTALL_DATA = $(INSTALL) -m0644 -p
 INSTALL_PROG = $(INSTALL) -m0755 -p
diff -r 7f653c6ce545 config/SunOS.mk
--- a/config/SunOS.mk   Mon Aug 25 12:37:36 2008 +0900
+++ b/config/SunOS.mk   Fri Aug 29 11:12:41 2008 +0900
@@ -14,7 +14,7 @@
 SHELL      = bash
-INSTALL      = ginstall
+INSTALL      ?= ginstall
 INSTALL_DIR  = $(INSTALL) -d -m0755 -p
 INSTALL_DATA = $(INSTALL) -m0644 -p
 INSTALL_PROG = $(INSTALL) -m0755 -p


Xen-ia64-devel mailing list