This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][XEN] public header: portability

To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][XEN] public header: portability
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 21 Aug 2008 11:18:41 +0100
Delivery-date: Thu, 21 Aug 2008 03:19:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C4D2FECD.263B2%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AckDdtO6El+bnm9qEd2gBAAX8io7RQAAHTSP
Thread-topic: [Xen-devel] [PATCH][XEN] public header: portability
User-agent: Microsoft-Entourage/
On 21/8/08 11:15, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

> On 21/8/08 11:03, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
>> Attached patch defines xen_*mb() macros for NetBSD.
>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> Since this has presumably never worked unmodified for NetBSD, it's not a
> compatibility issue. You should simply specify __XEN_INTERFACE_VERSION__ >=
> 0x00030208 and fix up any small build breakages that this causes in the NetBSD
> kernel sources.

Actually I suspect you're not specifying __XEN_INTERFACE_VERSION__ at all
right now. The easiest way to do so is to add it to your CPPFLAGS
(-D__XEN_INTERFACE_VERSION__=<whatever>), or NetBSD build system equivalent,
then it definitely gets defined correctly everywhere that you include Xen
public header files.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>