[Xen-devel] Re: [PATCH 6/7] bio-cgroup: Implement the bio-cgroup

[Ryo Tsuruta <ryov@xxxxxxxxxxxxx>]

Hi Yoshikawa-san,

> > +static void bio_cgroup_move_task(struct cgroup_subsys *ss,
> > +                           struct cgroup *cont,
> > +                           struct cgroup *old_cont,
> > +                           struct task_struct *p)
> > +{
> > +   struct mm_struct *mm;
> > +   struct bio_cgroup *biog, *old_biog;
> > +
> > +   if (bio_cgroup_disabled())
> > +           return;
> > +
> > +   mm = get_task_mm(p);
> > +   if (mm == NULL)
> > +           return;
> > +
> > +   biog = cgroup_bio(cont);
> > +   old_biog = cgroup_bio(old_cont);
> > +
> > +   mmput(mm);
> > +   return;
> > +}
> 
> Is this function fully implemented?

This function can be more simplified, there is some unnecessary code 
from old version.

> I tried to put a process into a group by writing to
> "/cgroup/bio/BGROUP/tasks" but failed.

Could you tell me what you actually did? I will try the same thing.

--
Ryo Tsuruta <ryov@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel