This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qe

To: Blue Swirl <blauwirbel@xxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu
From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Thu, 07 Aug 2008 17:21:58 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx, Anthony Liguori <anthony@xxxxxxxxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Delivery-date: Thu, 07 Aug 2008 08:22:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <f43fc5580808070806g19997fedxbf67fdf9d2060e4b@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080805150328.GT4478@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080806102338.GA4448@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <m37iauxqii.fsf@xxxxxxxxxxxxxxxxxxxxx> <20080806125055.GG4448@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4899AD19.8060606@xxxxxxxxxx> <20080806140132.GL4448@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4899B06F.2090101@xxxxxxxxxx> <20080806142526.GN4448@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080806221047.GE4486@implementation> <489AA532.7040006@xxxxxxxxxx> <f43fc5580808070806g19997fedxbf67fdf9d2060e4b@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20080501)
Blue Swirl wrote:
>> http://kraxel.fedorapeople.org/patches/qemu-xen/

> 0004-xenpv-groundwork.patch
> You dropped nodisk_ok support from vl.c.

Oh, there are *two* patchsets:

The first also includes some not-yet submitted work-in-progress bits.
It is against upstream qemu svn.  The second is against xen's qemu fork,
so the xen-related changes can get a test-drive there.

Especially the vl.c changes are very different in the two patch sets
because xen's vl.c looks very different (lot of CONFIG_DM conditional
code) and because I don't want to break the command line interface for
now to not break xend's expectations.

That doesn't mean that the nodisk_ok got lost.  It is only in the first
patchset though.

> 0005-xen-backend-core.patch
> container_of could go to osdep.h.

Will do.

> 0006-xen-console-backend.patch
> Not your fault, but a lot of places (at least ps2.c and
> slavio_serial.c) define some kind of ring buffers. Maybe these could
> be consolidated some time.

Will have a look if I find some time.

> 0007-xen-framebuffer-backend.patch
> After you optimized scancode2linux[], it looks like
> atkbd_set2_keycode[] and atkbd_unxlate_table[] are not needed.

Indeed.  Think I just ifdef them out and leave them in there as



Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>