This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu

To: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Wed, 6 Aug 2008 11:23:38 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, qemu-devel@xxxxxxxxxx, Anthony Liguori <anthony@xxxxxxxxxxxxx>
Delivery-date: Wed, 06 Aug 2008 03:24:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48997981.1030703@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Anthony Liguori <anthony@xxxxxxxxxxxxx>, qemu-devel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
References: <1217865045-10722-1-git-send-email-kraxel@xxxxxxxxxx> <48973F8E.8080109@xxxxxxxxxxxxx> <20080805104630.GM4478@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <489835A3.6030804@xxxxxxxxxx> <20080805112935.GO4478@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <48985336.2020709@xxxxxxxxxx> <20080805150328.GT4478@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080805154140.GV4478@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <48997981.1030703@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Gerd Hoffmann, le Wed 06 Aug 2008 12:14:25 +0200, a écrit :
> The rough way to merge would look like this:
>   - drop xen_console.[ch]
>   - drop xenfb.[ch]
>   - drop xen_machine_pv.c
>   - add xen.h
>   - add xen-machine.c
>   - add xen-backend.[ch]
>   - add xen-console.c
>   - add xen-framebuffer.c
>   - wind up stuff in the Makefiles.
>   - some global renames (domid -> xen_domid for example) as I took care
>     to prefix global xen variables & functions with xen_.
>   - probably some small fixups are needed ...

You forgot the _test_ stage.  You are basically asking us to replace our
well-tested implementation with your implementation, that's quite a
move.  You are not even providing a patch for us to check that nothing
has been left behind...

> Note that qemu-dm has a few optimizations in the qemu display code to
> avoid unneeded work.  I'd suggest to submit them upstream.

That's planned, yes.  But you too could do the same for the device
backend core for instance...

> The you can gradually move qemu-dm to be more upstream-ish while also
> updating xend accordingly.

That's what we are already doing in Ian's tree.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>