This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend dr

To: qemu-devel@xxxxxxxxxx
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend driver
From: Anthony Liguori <anthony@xxxxxxxxxxxxx>
Date: Fri, 01 Aug 2008 09:57:14 -0500
Cc: Andreas Färber <andreas.faerber@xxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 01 Aug 2008 07:58:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48903B96.6030407@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1217251078-6591-1-git-send-email-kraxel@xxxxxxxxxx> <1217251078-6591-5-git-send-email-kraxel@xxxxxxxxxx> <488DD618.5000504@xxxxxxxxxxxxx> <16E84423-5C51-4CBA-9D56-04CDE09312DF@xxxxxx> <48903B96.6030407@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20080501)
Gerd Hoffmann wrote:

+/* A convenient function for munging pixels between different depths */
BLT(SRC_T,DST_T,RSB,GSB,BSB,RDB,GDB,BDB)                        \
+    for (line = y ; line < (y+h) ; line++) {                \

There are similar conversion macros in the VGA code.  I don't know how
practical it would be to reuse them but it's at least worth looking at.
We created a file hw/pixel_ops.h to share code between vga.c and tcx.c,
probably it can be extended to serve Xen as well.

Uhm, well, it isn't that easy.  Unifying that looks like a big job in
itself.  pixel_ops.h as-is isn't very helpful for xen-framebuffer.  The
xen-framebuffer macro isn't very useful to others.

Okay, the xen-framebuffer macros aren't that big so it's not a huge deal. Was worth looking into though. Thanks!


Anthony Liguori

What IMHO would be most useful is a set of generic conversion functions,
operating on scanline level, much like the ones created by
vga_template.h, but without dependencies on vga.c internals.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>