RE: [Xen-devel] [PATCH 1/5] AMD IOMMU: bug fix and code cleanup

["Nakajima, Jun" <jun.nakajima@xxxxxxxxx>]

On 7/31/2008 5:27:45 AM, Wei Wang2 wrote:
> init.patch: Since device id covered by each iommu can never overlap,
> use a global device table instead of allocating private tables for
> each iommu. Migrate a few functions from pci_amd_iommu.c
>
> -Wei

+void __init enable_iommu(struct amd_iommu *iommu)
+{
+    unsigned long flags;
+
     spin_lock_irqsave(&iommu->lock, flags);

-    amd_iommu_msi_data_init (iommu, vector);
+    if ( iommu->enabled )
+        return;

I just scanned the code for a second, but you might want to add
spin_unlock_irqrestore(&iommu->lock, flags) before returning?


>
> Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
> --
> AMD Saxony, Dresden, Germany
> Operating System Research Center
>
> Legal Information:
> AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift):
> Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht
> Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC
> (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr.
> Hans-R. Deppe, Thomas McCoy
             .
Jun Nakajima | Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel