WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] serialize suspend-resume process

To: BVK Chaitanya <bayapuneni_chaitanya@xxxxxxxxxxxx>, <Xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] serialize suspend-resume process
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 31 Jul 2008 12:17:41 +0100
Cc:
Delivery-date: Thu, 31 Jul 2008 04:18:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48919D55.5000005@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acjy/wvhSi05JF7yEd2L3gAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] serialize suspend-resume process
User-agent: Microsoft-Entourage/11.4.0.080122
On 31/7/08 12:09, "BVK Chaitanya" <bayapuneni_chaitanya@xxxxxxxxxxxx> wrote:

> With current suspend-resume code, there is no way for DOM-0 to identify
> that DOM-U resume is completed.  It can potentially trigger suspend
> again before resume is completed.
> 
> Below patch makes suspend-resume process serialized.

It's already supposed to be serialised, and there's a loop in xen_suspend()
to deal with up to one queued suspend request. Your patch may deal with an
arbitrary number of queued suspend requests, but a sane dom0 control stack
should never issue more than one suspend request in a suspend-resume cycle.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel