Re: [Xen-devel] Re: [PATCH] ioemu-remote: ACPI S3 state wake up

["Trolle Selander" <trolle.selander@xxxxxxxxx>]

Don't leave the main rombios unprotected. I also added a comment to explain the "magic numbers", since their meaning is perhaps not as obvious as I thought, in particular now that we're no longer blanket-protecting the entire firmware area anymore.

/ Trolle

Signed-off-by: Trolle Selander <trolle.selander@xxxxxxxxxxxxx <mailto:trolle.selander@xxxxxxxxxxxxx>

On Wed, Jul 23, 2008 at 7:02 PM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:

Jean Guyader writes ("[PATCH] ioemu-remote: ACPI S3 state wake up"):

> ioemu-remote: The device model needs to write in the ACPI tables when it
> wakes up from S3 state.

I've applied this but I have to say these magic numbers
> -        if (xc_hvm_set_mem_type(xc_handle, domid, mem_type, 0xc0, 0x40))
> +        if (xc_hvm_set_mem_type(xc_handle, domid, mem_type, 0xc0, 0x20))
are pretty unpleasant!  Are they directly derived from addresses
specified in ACPI ?  I haven't looked ...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

restore_rombios_protect.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel