WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-changelog] [xen-unstable] libxc: Clean up xc_map_fo

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-changelog] [xen-unstable] libxc: Clean up xc_map_foreign_ranges() interface to hide the
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Wed, 23 Jul 2008 16:59:41 +0100
Delivery-date: Wed, 23 Jul 2008 09:00:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200807231550.m6NFoicJ028399@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <200807231550.m6NFoicJ028399@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Xen patchbot-unstable, le Wed 23 Jul 2008 08:50:44 -0700, a écrit :
> diff -r 351ce3b94e2d -r 7299346111fb tools/libxc/xc_private.h
> --- a/tools/libxc/xc_private.h        Wed Jul 23 13:31:57 2008 +0100
> +++ b/tools/libxc/xc_private.h        Wed Jul 23 16:39:46 2008 +0100
> @@ -184,8 +184,9 @@ static inline int do_sysctl(int xc_handl
>      return ret;
>  }
>  
> -int xc_map_foreign_ranges(int xc_handle, uint32_t dom,
> -                          privcmd_mmap_entry_t *entries, int nr);
> +void *xc_map_foreign_ranges(int xc_handle, uint32_t dom,
> +                            size_t size, int prot, size_t chunksize,
> +                            privcmd_mmap_entry_t entries[], int nentries);

Mmm, why chunksize?  Shouldn't entries[] provide it, for a more powerful
interface (each entry can have a different size)?

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>