WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel][PATCH][XSM][FLASK] Argument handling bugs in XSM:FLASK

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel][PATCH][XSM][FLASK] Argument handling bugs in XSM:FLASK
From: "George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>
Date: Fri, 18 Jul 2008 15:12:55 -0400
Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Delivery-date: Fri, 18 Jul 2008 12:14:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjpCkguhsK0xlT9Ed2XYQAWy5GONg==
Thread-topic: [Xen-devel][PATCH][XSM][FLASK] Argument handling bugs in XSM:FLASK
User-agent: Microsoft-Entourage/11.4.0.080122
The attached patch addresses a number of argument handling bugs in the
flask_op hypercall in the XSM:Flask module.  Thanks to Rafal Wojtczuk at
McAfee for reporting the issues and Tim Deegan at Citrix for providing an
initial patch.

This patch addresses the following issues:
 - bounds checking and validation on input arguments to flask_op
 - updated ABI/API, size and cmd are now uint32_t
 - updated userspace tools and libraries to account for ABI/API changes
 - implemented all copies using from/to guest, better portability
 - implemented upper bounds checking on op->cmd, op->size
 - implemented sanity checking on op->size and op->buf
 - implemented bit vector for checking from/to usage on op->cmd

Please do not hesitate to contact me on future issues/concerns/comments
related to XSM and the Flask module.

<Signed-off-by: George Coker, gscoker@xxxxxxxxxxxxxx>

-- 
George S. Coker, II <gscoker@xxxxxxxxxxxxxx>

Attachment: flask-argument-bug-071808.diff
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel][PATCH][XSM][FLASK] Argument handling bugs in XSM:FLASK, George S. Coker, II <=