WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] build problem with new ioemu

To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] build problem with new ioemu
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 18 Jul 2008 14:08:22 +0100
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Pat Campbell <plc@xxxxxxxxxx>
Delivery-date: Fri, 18 Jul 2008 06:08:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200807181459.24305.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acjo11rbmX2LqlTKEd2ESAAX8io7RQ==
Thread-topic: [Xen-devel] build problem with new ioemu
User-agent: Microsoft-Entourage/11.4.0.080122
On 18/7/08 13:59, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> Old code did:
>> /* Some versions of usbdevice_fs.h need __user to be defined for them.   */
>> /* This may (harmlessly) conflict with a definition in linux/compiler.h. */
>> #define __user
>> #include <linux/usbdevice_fs.h>
>> 
>> Not sure which is the better solution
>> 
>> Pat
> 
> This patch works. Tnx.
> 
> Keir: Please apply it.

IanJ is on it.

The old approach is better than linux/compiler.h since not all systems have
that header (and if they do, may not define __user).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel