WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] Adjust handle_hpet_broadcast to let it runbetter

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Adjust handle_hpet_broadcast to let it runbetter before broadcast exit
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Wed, 16 Jul 2008 16:33:05 +0800
Cc: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 16 Jul 2008 01:33:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <094BCE01AFBE9646AF220B0B3F367AAB0349995F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <094BCE01AFBE9646AF220B0B3F367AAB0349995F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjnB+FJROlfQBj7TOaQDz7mE/mMawAFk//g
Thread-topic: [Xen-devel] [PATCH] Adjust handle_hpet_broadcast to let it runbetter before broadcast exit
Resent as attachment.

Jimmy

On Wednesday, July 16, 2008 1:51 PM, Wei, Gang wrote:
> Adjust handle_hpet_broadcast to let it run better before broadcast
exit
> 
> Since hpet_broadcast_exit has been moved after interrupt enabled in C3
> case, so adjust the handler of hpet broadcast to adapt to this.
> Meanwhile, remove a freqently executed debug print line to simplify
the
> serial output.
> 
> Signed-off-by: Wei Gang <gang.wei@xxxxxxxxx>
> 
> diff -r 63317b6c3eab xen/arch/x86/hpet.c
> --- a/xen/arch/x86/hpet.c     Mon Jul 14 15:21:03 2008 +0100
> +++ b/xen/arch/x86/hpet.c     Wed Jul 16 12:43:52 2008 +0800
> @@ -97,8 +97,6 @@ static int reprogram_hpet_evt_channel(
>      delta = expire - now;
>      if ( delta <= 0 )
>      {
> -        printk(KERN_DEBUG "reprogram: expire(%"PRIx64") < "
> -               "now(%"PRIx64")\n", expire, now);
>          if ( !force )
>              return -ETIME;
>      }
> @@ -142,12 +140,10 @@ static void handle_hpet_broadcast(struct
>  {
>      cpumask_t mask;
>      s_time_t now, next_event;
> -    int cpu, current_cpu = smp_processor_id();
> +    int cpu;
> 
>      spin_lock(&ch->lock);
> 
> -    if ( cpu_isset(current_cpu, ch->cpumask) )
> -        printk(KERN_DEBUG "WARNING: current cpu%d in bc_mask\n",
> current_cpu);
>  again:
>      ch->next_event = STIME_MAX;
>      next_event = STIME_MAX;
> @@ -162,8 +158,6 @@ again:
>          else if ( per_cpu(timer_deadline, cpu) < next_event )
>              next_event = per_cpu(timer_deadline, cpu);
>      }
> -    if ( per_cpu(timer_deadline, current_cpu) <= now )
> -        cpu_set(current_cpu, mask);
> 
>      /* wakeup the cpus which have an expired event. */
>      evt_do_broadcast(mask);
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Attachment: hpet-broadcast-exit-after-intr-enabled.patch
Description: hpet-broadcast-exit-after-intr-enabled.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>