WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] clocksource=tsc

To: "dan.magenheimer@xxxxxxxxxx" <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] clocksource=tsc
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 15 Jul 2008 14:05:14 +0100
Cc: Dave Winchell <dwinchell@xxxxxxxxxxxxxxx>
Delivery-date: Tue, 15 Jul 2008 06:05:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080714115941000.00000080236@djm-pc>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjkZ5sqwfzsRK8bRLOogZ+uDOy+agBK8Gg8AAvqplAALhkLxQ==
Thread-topic: [PATCH] clocksource=tsc
User-agent: Microsoft-Entourage/11.4.0.080122
On 14/7/08 18:59, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> I'm sympathetic to the patch, but it looks like an ugly hack
>> right now.
> 
>> Since it should clearly only affect behaviour when the new
>> clocksource is explicitly selected...
> 
> Actually the ugliness is because the read_counter function
> and plt_mask are both u32 and I worried that changing them to
> a u64 would be too invasive.
> 
> So here's two possible replacement patches, one with those
> switched to u64 and the other with separate 32- and 64-bit
> read_counter functions.  Both are boot-tested with and
> without clocksource=tsc.

Changeset 18055 is what I had in mind. I split out the
read_counter-is-64-bit portion separately. The changeset needs a bit of
testing and it may need a tweak or two.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel