WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] minios: proper frees are now handled, so drop the FI

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] minios: proper frees are now handled, so drop the FIXME comment
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Tue, 1 Jul 2008 14:47:19 +0100
Delivery-date: Tue, 01 Jul 2008 06:47:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
minios: proper frees are now handled, so drop the FIXME comment

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

diff -r e7a77dc15d62 extras/mini-os/blkfront.c
--- a/extras/mini-os/blkfront.c Tue Jul 01 14:46:23 2008 +0100
+++ b/extras/mini-os/blkfront.c Tue Jul 01 14:47:15 2008 +0100
@@ -125,7 +125,6 @@
 
     dev->events = NULL;
 
-    // FIXME: proper frees on failures
 again:
     err = xenbus_transaction_start(&xbt);
     if (err) {
diff -r e7a77dc15d62 extras/mini-os/fbfront.c
--- a/extras/mini-os/fbfront.c  Tue Jul 01 14:46:23 2008 +0100
+++ b/extras/mini-os/fbfront.c  Tue Jul 01 14:47:15 2008 +0100
@@ -100,7 +100,6 @@
     s->in_cons = s->in_prod = 0;
     s->out_cons = s->out_prod = 0;
 
-    // FIXME: proper frees on failures
 again:
     err = xenbus_transaction_start(&xbt);
     if (err) {
@@ -408,7 +407,6 @@
         s->pd[i] = 0;
 
 
-    // FIXME: proper frees on failures
 again:
     err = xenbus_transaction_start(&xbt);
     if (err) {

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] minios: proper frees are now handled, so drop the FIXME comment, Samuel Thibault <=