| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH] mm: fix comment formatting in asm-generic/pgtabl
|
To: |
Rusty Russell <rusty@xxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH] mm: fix comment formatting in asm-generic/pgtable.h:__ptep_modify_prot_ |
|
From: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Date: |
Tue, 03 Jun 2008 00:53:43 +0100 |
|
Cc: |
Zachary Amsden <zach@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>, kvm-devel <kvm-devel@xxxxxxxxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Virtualization Mailing List <virtualization@xxxxxxxxxxxxxx>, Hugh Dickins <hugh@xxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx> |
|
Delivery-date: |
Mon, 02 Jun 2008 16:54:46 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<200806030946.00434.rusty@xxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<patchbomb.1212192268@localhost> <20080602111339.GB18586@xxxxxxx> <4843EF6A.20305@xxxxxxxx> <200806030946.00434.rusty@xxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 2.0.0.14 (X11/20080501) |
Rusty Russell wrote:
On Monday 02 June 2008 23:02:34 Jeremy Fitzhardinge wrote:
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
---
include/asm-generic/pgtable.h | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
===================================================================
--- a/include/asm-generic/pgtable.h
+++ b/include/asm-generic/pgtable.h
@@ -201,9 +201,11 @@
unsigned long addr,
pte_t *ptep)
{
- /* Get the current pte state, but zero it out to make it
- non-present, preventing the hardware from asynchronously
- updating it. */
+ /*
+ * Get the current pte state, but zero it out to make it
+ * non-present, preventing the hardware from asynchronously
+ * updating it.
+ */
Since there is debate over whether winged comments are a feature, I'm not sure
this can be termed a "fix".
I don't feel all that strongly about it in this case. I'm not a huge
fan of winged style for inline comments like this, but it is consistent
with the rest of the file, and the comment is (just) long enough to make
it not look completely stupid.
{
- /* The pte is non-present, so there's no hardware state to
- preserve. */
+ /*
+ * The pte is non-present, so there's no hardware state to
+ * preserve.
+ */
set_pte_at(mm, addr, ptep, pte);
}
This will fit in one line, no?
Yes, but changing it would mean going to the effort of regenerating the
patch.
J
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home