WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [bisected] Re: [PATCH 05 of 12] xen: add p2m mfn_list_li

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [bisected] Re: [PATCH 05 of 12] xen: add p2m mfn_list_list
From: Ingo Molnar <mingo@xxxxxxx>
Date: Mon, 2 Jun 2008 12:10:59 +0200
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sam Ravnborg <sam@xxxxxxxxxxxx>
Delivery-date: Mon, 02 Jun 2008 03:11:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <483D65E6.3020604@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1211550067@localhost> <a405e5f9ddf6f5f142ea.1211550072@localhost> <20080528122813.GA5502@xxxxxxx> <483D65E6.3020604@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Subject: make page-aligned data and bss less fragile
>
> Making a variable page-aligned by using 
> __attribute__((section(".data.page_aligned"))) is fragile because if 
> sizeof(variable) is not also a multiple of page size, it leaves 
> variables in the remainder of the section unaligned.
>
> This patch introduces two new qualifiers, __page_aligned_data and 
> __page_aligned_bss to set the section *and* the alignment of 
> variables.  This makes page-aligned variables more robust because the 
> linker will make sure they're aligned properly.  Unfortunately it 
> requires *all* page-aligned data to use these macros...

applied to -tip, thanks Jeremy. Created a new topic branch for the core 
bits of it: tip/build. Sam might want to pull from that topic branch 
eventually, once these changes pass testing in -tip.

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>