WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/4] HVM Virtual S3 --- Revised and resent

To: "Ke, Liping" <liping.ke@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/4] HVM Virtual S3 --- Revised and resent
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Sat, 24 May 2008 08:37:39 +0100
Delivery-date: Sat, 24 May 2008 00:37:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <391BF3CDD2DC0848B40ACB72FA97AD59036A7B81@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aci6Rwan30LCwMVNRjCgsXSrb2rzYwAOb9TQAAFWQHAAAIxGwAAAHx6dAACz6YAAAGA27AAfNwegAG4iWxMAGvX4wAAAeUDAABAy1+M=
Thread-topic: [Xen-devel] [PATCH 0/4] HVM Virtual S3 --- Revised and resent
User-agent: Microsoft-Entourage/11.4.0.080122
On 24/5/08 01:02, "Ke, Liping" <liping.ke@xxxxxxxxx> wrote:

> I have a rough look and just one thing, I noticed that in arch_vcpu_reset, if
> it is hvm, we don't do destroy_pagetables.

I think destroy_pagetables() is a bad thing to do when paging is on! We
re-adjust pagetable state when update_paging_modes() is called in
hvm_vcpu_reset_state(). To my knowledge that is the correct way to go about
this. Certainly it's the only way that didn't crash for me in some
circumstances. :-)

> Maybe it will have some problems. Since now s3 sleep down in protected mode
> yet wake up in real mode, so cr3 used in protected mode when sleeping down is
> not freed. It will cause
> Domain_heap use count != 0, domain_destroy could not be completed totally,
> some resource is not freed.

I hope not and I'm pretty sure not. Do keep an eye out for it though.

> We found the problem when trying to create a vtd device assigned hvm guest,
> then destroy it and redo create, yet
> It failed saying "vtd device is assigned aready".
> We tried to log this cr3, put_page of this cr3, it works, so we need
> vcpu_destroy_pagetables.
> 
> Yet I am not sure whether the problem still exist after your restructure. I
> will do further try next Monday:)

Yes please!

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel