WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH 1/5] VT-d support for PV guests

To: "Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 1/5] VT-d support for PV guests
From: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Date: Mon, 19 May 2008 14:41:42 -0700
Cc: "Han, Weidong" <weidong.han@xxxxxxxxx>
Delivery-date: Mon, 19 May 2008 14:42:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <18481.58194.426124.386871@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <18481.58194.426124.386871@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aci57zKSAFcopjo+QZKyNOdLP4P9xAACVoew
Thread-topic: [Xen-devel] [PATCH 1/5] VT-d support for PV guests
+    if ( !root_present(root_entry[bus]) )
     {
-        printk("---- print_vtd_entries %d ----\n", i++);
+       unmap_vtd_domain_page(root_entry);
+       printk("    root_entry[%x] not present\n", bus);
+       return;
+    } 

Why is the indentation not working?  Are you using tabs instead of 4
spaces for indentation?

It's good that you fixed print_vtd_entries().  I always wanted do that
but never got high enough in the priority.

Allen


>-----Original Message-----
>From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
>[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of 
>Espen Skoglund
>Sent: Monday, May 19, 2008 1:30 PM
>To: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: [Xen-devel] [PATCH 1/5] VT-d support for PV guests
>
>Page table debug output improvements
>
>Signed-off-by: Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel