WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] VMX status report. Xen: #17630 & Xen0: #540 -- blocked

To: "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx>, "Kevin Wolf" <kwolf@xxxxxxx>
Subject: RE: [Xen-devel] VMX status report. Xen: #17630 & Xen0: #540 -- blocked
From: "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>
Date: Fri, 16 May 2008 09:38:31 +0800
Cc: "Li, Haicheng" <haicheng.li@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 15 May 2008 18:39:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <18476.6533.343767.167852@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <FC1D1B23302A22499C60C967336B2AE002C9AE25@xxxxxxxxxxxxxxxxxxxxxxxxxxxx><18474.49834.442492.313331@xxxxxxxxxxxxxxxxxxxxxxxx><FC1D1B23302A22499C60C967336B2AE002C9B25F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx><FF386CB4AE0E4648B0A96060EC00F36CA72200@xxxxxxxxxxxxxxxxxxxxxxxxxxxx><482BFBBB.6030904@xxxxxxx><FF386CB4AE0E4648B0A96060EC00F36CA72230@xxxxxxxxxxxxxxxxxxxxxxxxxxxx><482C0751.5000703@xxxxxxx> <18476.6533.343767.167852@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aci2e+3jIn5IZJY2TD2yL+J9ueBxBAAdstSA
Thread-topic: [Xen-devel] VMX status report. Xen: #17630 & Xen0: #540 -- blocked
Hi, Ian,
    In your new patch, if find_protocol() function returns NULL, then you will 
let drv = &bdrv_raw, it is just guessing the image to be raw, I remember you 
mentioned it as a security problem. So I don't find any difference as the 
following one, it just reverts the change in block.c in C/S 17606. 

diff -r 86587698116d tools/ioemu/block.c
--- a/tools/ioemu/block.c       Wed May 14 14:12:53 2008 +0100
+++ b/tools/ioemu/block.c       Fri May 16 09:24:44 2008 +0800
@@ -254,7 +254,7 @@ static BlockDriver *find_protocol(const
 #endif
     p = strchr(filename, ':');
     if (!p)
-        return NULL; /* do not ever guess raw, it is a security problem! */
+        return &bdrv_raw;
     len = p - filename;
     if (len > sizeof(protocol) - 1)
         len = sizeof(protocol) - 1;



-----Original Message-----
From: Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx] 
Sent: 2008年5月15日 19:08
To: Kevin Wolf
Cc: Xu, Dongxiao; Li, Haicheng; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] VMX status report. Xen: #17630 & Xen0: #540 -- blocked

Could those of you having this problem please try the attached patch ?
I have tested this one much more thoroughly :-/.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel