WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] linux/balloon: don't allow ballooning down a dom

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] linux/balloon: don't allow ballooning down a domain below a reasonable limit
From: "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx>
Date: Wed, 14 May 2008 18:41:58 -0600
Cc: Ky Srinivasan <KSrinivasan@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "keir.fraser@xxxxxxxxxxxxx" <keir.fraser@xxxxxxxxxxxxx>, "garloff@xxxxxxx" <garloff@xxxxxxx>
Delivery-date: Wed, 14 May 2008 17:47:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <48295A7F.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Oracle Corporation
Reply-to: "dan.magenheimer@xxxxxxxxxx" <dan.magenheimer@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aci2JHl0RsCNy/t+R6SFiOeOCxRDnA==
I see.  Sorry I missed this in the earlier thread.  I can
confirm that the patch below works in a module.

Keir, the existing checked in balloon.c doesn't work properly
when compiled as a module so Jan's patch should be applied.

> -----Original Message-----
> From: Jan Beulich [mailto:jbeulich@xxxxxxxxxx]
> Sent: Tuesday, May 13, 2008 1:08 AM
> To: dan.magenheimer@xxxxxxxxxx
> Cc: keir.fraser@xxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxx; Ky
> Srinivasan; garloff@xxxxxxx
> Subject: RE: [Xen-devel] [PATCH] linux/balloon: don't allow ballooning
> down a domain below a reasonable limit
> 
> 
> >>> "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> 09.05.08 22:38 >>>
> >Hmmm... it appears to me that minimum_target() doesn't
> >work when balloon.c is built as a module (always returns 0).
> >
> >Can you confirm/deny?
> 
> Yes, that's a change Keir did after noticing that I used an improper
> variable (totalram_pages) to base the calculation upon in the 
> modular case
> (max_pfn is not exported anymore in newer kernels). It should 
> be possible
> though to base the calculation on num_physpages, as in the 
> patch below.
> 
> Jan
> 
> --- head-2008-04-15.orig/drivers/xen/balloon/balloon.c
> +++ head-2008-04-15/drivers/xen/balloon/balloon.c
> @@ -198,8 +198,8 @@ static unsigned long current_target(void
>  static unsigned long minimum_target(void)
>  {
>  #ifndef CONFIG_XEN
> -     return 0;
> -#else
> +#define max_pfn num_physpages
> +#endif
>       unsigned long min_pages, curr_pages = current_target();
>  
>  #define MB2PAGES(mb) ((mb) << (20 - PAGE_SHIFT))
> @@ -227,7 +227,7 @@ static unsigned long minimum_target(void
>  
>       /* Don't enforce growth */
>       return min(min_pages, curr_pages);
> -#endif
> +#undef max_pfn
>  }
>  
>  static int increase_reservation(unsigned long nr_pages)
> 
> 
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel