Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen

To:	"Liu, Jinsong" <jinsong.liu@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Tue, 13 May 2008 09:55:51 +0100
Delivery-date:	Tue, 13 May 2008 01:56:28 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<9D7649D18729DE4BB2BD7B494F7FEDC201400CB9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Aci0pum5DchKJJryTjCAyBnEoEeG2AAMDsoT
Thread-topic:	[Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen
User-agent:	Microsoft-Entourage/11.4.0.080122

On 13/5/08 04:10, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

> Get ACPI Px from dom0 and chose Px controller
> 
> Add platform op hypercall case to get ACPI Px info from dom0.
> Chose Px controller from dom0 (cpufreq=dom0-kernel)
> or hypervisor (cpufreq=xen-cpufreq)

No gcc-specific attributes in the public header files. This means no
__attribute__((packed)). Please fix that.

Also why declare a local variable 'a' in your changes to common/domain.c?

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen