WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/

Home

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] msix: revoke correct amount of msi-x related iom

from [Neil Turton]

[Permanent Link][Original]

To:	Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] msix: revoke correct amount of msi-x related iomem
From:	Neil Turton <nturton@xxxxxxxxxxxxxx>
Date:	Tue, 06 May 2008 17:31:49 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 06 May 2008 09:32:15 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<18459.22471.351306.107348@xxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<18459.22471.351306.107348@xxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Thunderbird 2.0.0.0 (X11/20070326)

Espen Skoglund wrote:
> +                        self.msix_entries = (message_cont_lo + \
> +                                             message_cont_hi << 8) \
> +                                             & MSIX_SIZE_MASK

That still doesn't look right to me since "+" binds tighter than "<<".
I think it needs some more parentheses around "message_cont_hi << 8", at
least if I've understood what the code's supposed to do.

Cheers, Neil.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] msix: revoke correct amount of msi-x related iomem, Espen Skoglund Re: [Xen-devel] [PATCH] msix: revoke correct amount of msi-x related iomem, Neil Turton <= Re: [Xen-devel] [PATCH] msix: revoke correct amount of msi-x related iomem, Espen Skoglund

Previous by Date:	Re: [Xen-devel] Vanilla Linux 64-bit paravirt guest support, Mark McLoughlin
Next by Date:	Re: [Xen-devel] [RFC] PVFB: Add refresh period to XenStore parameters?, Samuel Thibault
Previous by Thread:	[Xen-devel] [PATCH] msix: revoke correct amount of msi-x related iomem, Espen Skoglund
Next by Thread:	Re: [Xen-devel] [PATCH] msix: revoke correct amount of msi-x related iomem, Espen Skoglund
Indexes:	[Date] [Thread] [Top] [All Lists]

This site is hosted by Citrix