WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] c/s 17565 build error on PAE system.

To: "Li, Haicheng" <haicheng.li@xxxxxxxxx>
Subject: Re: [Xen-devel] c/s 17565 build error on PAE system.
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Sun, 4 May 2008 11:30:01 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 04 May 2008 03:30:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <FC1D1B23302A22499C60C967336B2AE002BACF21@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, "Li, Haicheng" <haicheng.li@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <FC1D1B23302A22499C60C967336B2AE002BACF21@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Hello,

Li, Haicheng, le Sun 04 May 2008 10:56:13 +0800, a écrit :
> multi.c: In function 'shadow_vram_get_l1e':
> multi.c:1275: warning: cast from pointer to integer of different size

Ergl, I thought I had checked the PAE compilation too, but apparently
not. Here is a patch.


Fix cast from pointer into physical offset.

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

diff -r b936b8ee02bb xen/arch/x86/mm/shadow/multi.c
--- a/xen/arch/x86/mm/shadow/multi.c    Fri May 02 17:06:53 2008 +0100
+++ b/xen/arch/x86/mm/shadow/multi.c    Sun May 04 11:29:28 2008 +0100
@@ -1272,7 +1272,7 @@ static inline void shadow_vram_get_l1e(s
         if ( count_info == 1 )
             /* Initial guest reference, record it */
             d->dirty_vram->sl1ma[i] = pfn_to_paddr(mfn_x(sl1mfn))
-                | ((paddr_t) sl1e & ~PAGE_MASK);
+                | ((unsigned long) sl1e & ~PAGE_MASK);
     }
 }
 
@@ -1295,7 +1295,7 @@ static inline void shadow_vram_put_l1e(s
         u32 count_info = page->u.inuse.type_info & PGT_count_mask;
         int dirty = 0;
         paddr_t sl1ma =  pfn_to_paddr(mfn_x(sl1mfn))
-            | ((paddr_t) sl1e & ~PAGE_MASK);
+            | ((unsigned long) sl1e & ~PAGE_MASK);
 
         if ( count_info == 1 ) {
             /* Last reference */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>