WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] ioemu: pump SDL events on resize

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] ioemu: pump SDL events on resize
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Fri, 2 May 2008 11:23:08 +0100
Delivery-date: Fri, 02 May 2008 03:24:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080502102133.GA4819@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
References: <20080502102133.GA4819@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Samuel Thibault, le Fri 02 May 2008 11:21:33 +0100, a écrit :
> ioemu: pump SDL events on resize
> 
> When sdl_resize resizes the SDL window, some window manager send back
> a ConfigureNotify event, which triggers a SDL_VIDEORESIZE event. That
> event, however, is seen only much later, on the next VGA refresh
> round. If the guest quickly switches to another resolution in between,
> the SDL_VIDEORESIZE event makes us erroneously rescale that new
> resolution into the old one.
> 
> This patch makes us pump that window manager event, so that no
> SDL_VIDEORESIZE event is generated.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

Oops, I sent an old patch, here is a proper one:

diff -r 7190027c2da8 tools/ioemu/sdl.c
--- a/tools/ioemu/sdl.c Thu May 01 18:56:04 2008 +0100
+++ b/tools/ioemu/sdl.c Fri May 02 10:47:36 2008 +0100
@@ -235,6 +235,9 @@ static void sdl_resize(DisplayState *ds,
 
  again:
     screen = SDL_SetVideoMode(w, h, 0, flags);
+
+    /* Process any WM-generated resize event */
+    SDL_PumpEvents();
 
     if (!screen) {
         fprintf(stderr, "Could not open SDL display: %s\n", SDL_GetError());

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>