xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] Allow direct hypercalls

from [John Levon]

[Permanent Link][Original]

To:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] Allow direct hypercalls
From:	John Levon <john.levon@xxxxxxx>
Date:	Thu, 1 May 2008 16:39:54 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Thu, 01 May 2008 09:02:19 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<C43F9A5F.202C7%keir.fraser@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<9a5c6e3620d83f9354e3.1209560191@xenbld> <C43F9A5F.202C7%keir.fraser@xxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.6i

On Thu, May 01, 2008 at 04:03:43PM +0100, Keir Fraser wrote:

> > # HG changeset patch
> > # User john.levon@xxxxxxx
> > # Date 1209521783 25200
> > # Node ID 9a5c6e3620d83f9354e3eedbc4ef24a7a5ad752e
> > # Parent  f477f895f78752bb9fa2e6ee6c1d09b6a8cd3230
> > Allow direct hypercalls
> > 
> > For PV guests, there's no reason to force use of the indirect hypercall
> > mechanism. Allow it. Also allow TRAP_INSTR to be used from assembly.
> > 
> > Signed-off-by: John Levon <john.levon@xxxxxxx>
> 
> Well, I suppose there is no reason. But since the instructions are not going
> to change you could just as well just open-code them, or define your own
> macro. _ASM isn't even a macro name that we use anywhere else in the public
> headers.

We're doing our best to try and merge our tree with your upstream. I
don't quite understand why you're refusing such simple, non-intrusive
changes. Is it really good coding practice to needlessly duplicate
stuff?

regards,
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] Allow direct hypercalls, john . levon Re: [Xen-devel] [PATCH] Allow direct hypercalls, Keir Fraser Re: [Xen-devel] [PATCH] Allow direct hypercalls, John Levon <= Re: [Xen-devel] [PATCH] Allow direct hypercalls, Ian Campbell Re: [Xen-devel] [PATCH] Allow direct hypercalls, John Levon

Previous by Date:	Re: [Xen-devel] Why is STP turned off?, Keir Fraser
Next by Date:	Re: [Xen-devel] [PATCH] Allow direct hypercalls, John Levon
Previous by Thread:	Re: [Xen-devel] [PATCH] Allow direct hypercalls, Keir Fraser
Next by Thread:	Re: [Xen-devel] [PATCH] Allow direct hypercalls, Ian Campbell
Indexes:	[Date] [Thread] [Top] [All Lists]