This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Tue, 29 Apr 2008 18:02:34 +0800
Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 29 Apr 2008 03:03:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4816E16C.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <094BCE01AFBE9646AF220B0B3F367AAB02FE2C75@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4815B6FE.76E4.0078.0@xxxxxxxxxx> <094BCE01AFBE9646AF220B0B3F367AAB030282DA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4816E16C.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcipxVKHSo9vulg4S4Otd1xPipO4MwAFRmvA
Thread-topic: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen
On Tuesday, April 29, 2008 2:51 PM, Jan Beulich wrote:
>>>> "Wei, Gang" <gang.wei@xxxxxxxxx> 29.04.08 02:50 >>>
>> On Monday, April 28, 2008 5:38 PM, Jan Beulich wrote:
>>>>>> "Wei, Gang" <gang.wei@xxxxxxxxx> 25.04.08 07:09 >>>
>>>> Handle dom0_max_vcpus < nr_pcpu cases, e.g. UP dom0.
>>>> Just try to pass info about all acpi processors to xen even in such
>>>> cases. 
>>>> Signed-off-by: Tian Kevin <kevin.tian@xxxxxxxxx>
>>>> Signed-off-by: Wei Gang <gang.wei@xxxxxxxxx>
>>> Are the changes done here native-compatible? They don't really look
>>> they are from a brief inspection... I'd be glad to read a closer
>>> explanation of what is being attempted here.
>> These changes should be native-compatible. We are attempting to make
>> ACPI info parsing work for all physical cpus even dom0 vcpu nr < phys
>> cpu nr. UP dom0 is a case requested by Keir for xen server probably
>> in that way. Without these changes, only BSP ACPI info can be parsed
>> passed to HV. Is that clear for you? Or any further comments?
> I understand the intention, but I'm worried about breaking native
> kernels: If the changes you made are appropriate for native, then
> why aren't they upstream? And if they aren't or if there is any doubt,
> then they ought to at least be contained in #ifdef CONFIG_XEN blocks
> (but of course I'd much prefer not having many of these in generic
> code, and even more in ACPI CA code).

Most of these changes don't have any impact if no additional linux
kernel parameter (xen_processor_pmbits=) was added to kernel cmdline by
Xen or manually in grub.conf. Is it still necessary to add #ifdef
CONFIG_XEN even if those changes have no impact by default?


Xen-devel mailing list