 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Fix deadlock in schedule.c at TRACE mode
| To: | NISHIGUCHI Naoki <nisiguti@xxxxxxxxxxxxxx>, Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Fix deadlock in schedule.c at TRACE mode |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Thu, 24 Apr 2008 08:29:00 +0100 |
| Delivery-date: | Thu, 24 Apr 2008 00:29:13 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <481030A8.7080506@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acil3N0MG+cq7hHQEd2pogAWy6hiGQ== |
| Thread-topic: | [Xen-devel] [PATCH] Fix deadlock in schedule.c at TRACE mode |
| User-agent: | Microsoft-Entourage/11.4.0.080122 |
On 24/4/08 08:03, "NISHIGUCHI Naoki" <nisiguti@xxxxxxxxxxxxxx> wrote: >> 2)About fixing code, >> I think __trace_var() should fix for this issue not schedule() >> This issue cannot be fixed by modify the __trace_var()? > > Thanks for your advise. > I agree with you. > I fixed this deadlock using tasklet in trace.c. > > Here is the patch. Thanks. This was my bad as I removed the old softirq and couldn't see a reason not to call wake() directly. I'll add a comment when I apply your patch. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Why the machine address is out of the end of real physical memory?, Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] VMX status report. Xen: #17513 & Xen0: #524 -- one new issue, Li, Haicheng |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Fix deadlock in schedule.c at TRACE mode, NISHIGUCHI Naoki |
| Next by Thread: | [Xen-devel] [PATCH] xenbaked: Fix access to trace buffer after xentrace changes, NISHIGUCHI Naoki |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
