This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Fix xenstore-client.c compile

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Fix xenstore-client.c compile
From: john.levon@xxxxxxx
Date: Tue, 15 Apr 2008 14:54:58 -0700
Delivery-date: Mon, 21 Apr 2008 10:06:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Resent-date: Mon, 21 Apr 2008 18:06:28 +0100
Resent-date: Mon, 21 Apr 2008 18:06:28 +0100
Resent-from: john.levon@xxxxxxx
Resent-message-id: <20080421170628.GB16767@xxxxxxxxxxxxxxxxx>
Resent-sender: John Levon <johnlev@xxxxxxxxxxxxxxxxx>
Resent-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User john.levon@xxxxxxx
# Date 1208291972 25200
# Node ID 9252f597874dde20b03fd3ba7d85fd1dd45d4e54
# Parent  8c0eab12df75f997458fad96304cc7927e8ef90c
Fix xenstore-client.c compile

errx() is not necessarily defined as a never-returns function. Fix
lookup_mode() to account for this.

Signed-off-by: John Levon <john.levon@xxxxxxx>

diff --git a/tools/xenstore/xenstore_client.c b/tools/xenstore/xenstore_client.c
--- a/tools/xenstore/xenstore_client.c
+++ b/tools/xenstore/xenstore_client.c
@@ -450,8 +450,9 @@ static enum mode lookup_mode(const char 
        return MODE_write;
     else if (strcmp(m, "read") == 0)
        return MODE_read;
-    else
-       errx(1, "unknown mode %s\n", m);
+    errx(1, "unknown mode %s\n", m);
+    return 0;

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Fix xenstore-client.c compile, john . levon <=