xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] Make ACPI DMAR parsing more robust

from [Espen Skoglund]

[Permanent Link][Original]

To:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] Make ACPI DMAR parsing more robust
From:	Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>
Date:	Thu, 3 Apr 2008 11:32:23 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx, Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>
Delivery-date:	Thu, 03 Apr 2008 03:33:35 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<C41A6E4C.1EBF0%keir.fraser@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<18419.47951.625663.623377@xxxxxxxxxxxxxxxxxx> <C41A6E4C.1EBF0%keir.fraser@xxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Right.  Depth *should* always be >= 1, but from my experience one can
not always trust the info in the tables to be correct.  Better be on
the safe side.

        eSk


[Keir Fraser]
> Regarding the table length sanity check -- depth is set to the
> number of acp_pci_path structures in the table. But then we only
> follow the path to depth-1. Is that correct?

> Also I changed the test to '--depth >= 0' which is equivalent and a
> bit easier to read imo.

>  -- Keir


> On 2/4/08 17:58, "Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx> wrote:

>> Parsing ACPI related VT-d tables may cause infinite loop due to u8
>> value wraparound.  Also add sanity check on table length entry.
>> 
>> eSk
>> 
>> 
>> Signed-off-by: Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] Make ACPI DMAR parsing more robust, Espen Skoglund Re: [Xen-devel] [PATCH] Make ACPI DMAR parsing more robust, Keir Fraser Re: [Xen-devel] [PATCH] Make ACPI DMAR parsing more robust, Espen Skoglund <=

Previous by Date:	Re: [Xen-devel] [PATCH] Make ACPI DMAR parsing more robust, Keir Fraser
Next by Date:	Re: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA, Andre Przywara
Previous by Thread:	Re: [Xen-devel] [PATCH] Make ACPI DMAR parsing more robust, Keir Fraser
Next by Thread:	[Xen-devel] problems compiling Xen 3.1.3 after making changes to the config, Girish V
Indexes:	[Date] [Thread] [Top] [All Lists]