Re: [Xen-devel] [PATCH] incorrect xfree for mini-os

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>]

Keir Fraser, le Wed 02 Apr 2008 15:45:43 +0100, a écrit :
> On 2/4/08 11:52, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx> wrote:
> 
> > INAKOSHI Hiroya, le Wed 02 Apr 2008 19:43:29 +0900, a écrit :
> >> xfree in extras/mini-os/lib/xmalloc.c is incorrect.
> >> 
> >> It has to check first if the memory to free is so big as to be freed
> >> directly by free_pages.
> >> 
> >> mini-os domains crash without this patch if they don't configure vfb
> >> correctly.
> >> 
> >> Signed-off-by: INAKOSHI Hiroya <inakoshi.hiroya@xxxxxxxxxxxxxx>
> > 
> > Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
> 
> Applied, but shouldn't the checks that this patch skips work okay even for
> big allocations made via xmalloc_whole_pages()?

The "hdr will be on same page" will typically not work when aligning the
big area on pages.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel