This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] incorrect xfree for mini-os

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] incorrect xfree for mini-os
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Wed, 2 Apr 2008 23:40:27 +0200
Cc: INAKOSHI Hiroya <inakoshi.hiroya@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 02 Apr 2008 14:54:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C4195AA7.1EB5F%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, INAKOSHI Hiroya <inakoshi.hiroya@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <20080402105248.GE4618@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C4195AA7.1EB5F%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Keir Fraser, le Wed 02 Apr 2008 15:45:43 +0100, a écrit :
> On 2/4/08 11:52, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx> wrote:
> > INAKOSHI Hiroya, le Wed 02 Apr 2008 19:43:29 +0900, a écrit :
> >> xfree in extras/mini-os/lib/xmalloc.c is incorrect.
> >> 
> >> It has to check first if the memory to free is so big as to be freed
> >> directly by free_pages.
> >> 
> >> mini-os domains crash without this patch if they don't configure vfb
> >> correctly.
> >> 
> >> Signed-off-by: INAKOSHI Hiroya <inakoshi.hiroya@xxxxxxxxxxxxxx>
> > 
> > Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
> Applied, but shouldn't the checks that this patch skips work okay even for
> big allocations made via xmalloc_whole_pages()?

The "hdr will be on same page" will typically not work when aligning the
big area on pages.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>