This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [Patch] [docs]: Fix HVM user documentation

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [Patch] [docs]: Fix HVM user documentation
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Wed, 2 Apr 2008 17:45:02 +0100
Cc: Andre Przywara <andre.przywara@xxxxxxx>
Delivery-date: Wed, 02 Apr 2008 09:45:28 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47F21A65.5020109@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <47F21A65.5020109@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6 (enterprise 0.20070907.709405)
Hi there,

Thanks for doing this.  Any attention to the user manual is appreciated, since 
it's got somewhat out of date since it was originally created!

> For example, to create a 2GB sparse file-backed virtual block device
>-(actually only consumes 1KB of disk):
>+(actually only consumes no disk space at all):

s/only consumes/ consumes/

I guess strictly it doesn't consume *no* disk space but it's near enough none!

>+kernel &        The HVM firmware loader, {\small 
>{\tt /usr/lib/xen/boot/hvmloader}}\\

I seem to remember Daniel Berrange making a patch to enable direct kernel boot 
(without a bootloader) which changed this option's meaning, added a similar 
option, or something like that.  I don't know if it's in mainline yet.  It's 
probably not that important for the user manual at this stage (not as 
important as getting the manual more up to date!), just thought I'd mention 

>+disk & Defines the disk devices you want the domain to have access to, and 
>what you want them accessible as. If using a physical device as the HVM 
>guest's disk, each disk entry is of the form 
> {\small {\tt phy:UNAME,ioemu:DEV,MODE,}}
I don't *think* you need to put ioemu in there anymore since, for an HVM 
guest, I believe Xen creates both PV and emulated versions of a disk device 
simultaneously these days.

>-in the VMX guest's console first to prevent data loss. Then execute the 
>+in the HVM guest's console, for Windows use Start -> Shutdown first to 
>+data loss. Depending on the configuration the guest will be automatically
>+destroyed, otherwise execute the command 

Perhaps we should s/will/may/ here?
>+{\bfseries Ctrl+Alt+2} switches from guest VGA window to the control window.
>Typing {\small {\tt help }} shows the control commands help. For example, 'q' 
>is the command to destroy the HVM guest.\\ 

I think this is disabled for security on some distributions.  Again, may not 
matter, but worth noting.

> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> Please review and apply to 3.3-unstable as well as 3.2-testing.

Sorry to make so many nitpicks :-)  Your changes are good and can quite 
happily go in as-is.  If you fancy refining them any more or cooking up a 
follow-up patch, then I hope these comments are useful to you.


Push Me Pull You - Distributed SCM tool (http://www.cl.cam.ac.uk/~maw48/pmpu/)

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>