WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] AMD IOMMU: Defer IO pagetable construction until

To: Wei Wang2 <wei.wang2@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] AMD IOMMU: Defer IO pagetable construction until device assignment
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 02 Apr 2008 15:52:07 +0100
Delivery-date: Wed, 02 Apr 2008 07:53:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1207145594.3980.28.camel@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AciU0R8LXYkYlADEEd2zswAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] AMD IOMMU: Defer IO pagetable construction until device assignment
User-agent: Microsoft-Entourage/11.4.0.080122
On 2/4/08 15:13, "Wei Wang2" <wei.wang2@xxxxxxx> wrote:

> During HVM domain creation, I/O page tables are filled by coping p2m
> entries from p2m table, which is a useless step for non-passthru domain.
> This patch defers I/O page table construction until the moment of device
> assignment. In case that pci devices are never assigned or hot plugged,
> the unnecessary duplication will be avoid.

You can't duplicate p2m_lock() and p2m_unlock(). Why do you need to protect
your new function with that lock anyway?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel