WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [RFC][PATCH] Use ioemu block drivers through blktap

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [RFC][PATCH] Use ioemu block drivers through blktap
From: Kevin Wolf <kwolf@xxxxxxx>
Date: Mon, 31 Mar 2008 13:11:57 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 31 Mar 2008 04:17:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <18416.45243.850593.642052@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <47D569F6.1010209@xxxxxxx> <47D91D3D.1000005@xxxxxxx> <18413.3411.635161.295233@xxxxxxxxxxxxxxxxxxxxxxxx> <47F0AA6E.2050909@xxxxxxx> <18416.45243.850593.642052@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20060911)
Ian Jackson schrieb:
> If this cleanup is really necessary, then that will cause problems for
> future runs.  If not then the cleanup isn't really necessary :-).

I think in your classification they are "not really necessary" cleanups.
But that's no reason not to do them, right?

> Leftover named pipes, for example, aren't really a big problem and can
> just be garbage collected at some point (provided their names are
> sufficiently unique).
> 
> I haven't eyeballed all of the new qemu blktap arrangements in detail.
> What processes are there and why can't the process at the other end of
> the pipe do the cleanup ?

As for uniqueness, they have the domain ID as part of their filename. If
a pipe already exists it is reused, so no real problem here, it's just
not nice to leave too many of them lying around IMHO.

Think of qemu-dm as a server providing access to disk images. If you
want the process at the other end to do the cleanup, you have the client
cleaning up server pipes. Even though this sounds a bit odd, it might
work for us in principle as the client is a single blktapctrl process
(or even xend?). One problem would be that qemu-dm could provide a pipe
which is not used by any client (if you don't use tap:ioemu block
devices) and thus won't be cleaned up.

Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel