Re: [Xen-devel] [PATCH][TOOLS] libfsimage: portability fixes

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Thu, Mar 27, 2008 at 04:16:51PM +0100, Christoph Egger wrote:

> On Thursday 27 March 2008 12:05:30 Ian Jackson wrote:
> > Christoph Egger writes ("[Xen-devel] [PATCH][TOOLS] libfsimage: portability 
> fixes"):
> > > -${CC:-gcc} -o ext2-test ext2-test.c -lext2fs >/dev/null 2>&1
> > > +if test -z ${CC}; then CC="gcc"; fi
> > > +${CC} -o ext2-test ext2-test.c -lext2fs >/dev/null 2>&1
> > > +
> >
> > This also seems to serve no purpose as far as I can tell.
> 
> This is for the ancient Solaris /bin/sh.  If John Levon confirms that
> this and that the $(SHELL)  mentioned in your other mail 
> are NOT needed/required to not break Solaris, you can undo these two changes.

It's not needed for the Bourne shell, no.

regards,
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel