WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: changeset 17265

To: Stefan Berger <stefanb@xxxxxxxxxx>
Subject: [Xen-devel] Re: changeset 17265
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 24 Mar 2008 15:25:03 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 24 Mar 2008 08:26:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <OFA471D71B.F888AE66-ON85257416.0054043E-85257416.0054662B@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AciNwzsdeWa2gvm2EdyiPwAWy6hiGQ==
Thread-topic: changeset 17265
User-agent: Microsoft-Entourage/11.4.0.080122
No, I’m not 100% sure, but without this change I get a backtrace in xend.log because append() takes only one argument. Looking at the line immediately above I determined that this was most likely the correct change to make, and that the previous placement of the square bracket was a typo.

 -- Keir

On 24/3/08 15:21, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:


Keir,

  I just saw the changeset 17265. Are you sure that this is correct?

--- a/tools/python/xen/xend/XendConfig.py                Thu Mar 20 10:48:21 2008 +0000
+++ b/tools/python/xen/xend/XendConfig.py                Thu Mar 20 17:45:00 2008 +0000
@@ -991,7 +991,7 @@ class XendConfig(dict):
                                    dev_type, dev_cfg = self['devices'][dev_uuid]
                                    is_bootable = dev_cfg.get('bootable', 0)
                                    config.append(['bootable', int(is_bootable)])
-                                   config.append(['VDI'], dev_cfg.get('VDI', ''))
+                                   config.append(['VDI', dev_cfg.get('VDI', '')])
 
                                sxpr.append(['device', config])


I get a line in the VM's config file that looks like this

        (VDI  )

It's missing the UUID now.
Even though the format was different than of the 'bootable' above, I did get the correct output with it,

   Stefan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>