Ian Jackson, le Tue 04 Mar 2008 11:38:44 +0000, a écrit :
> Samuel Thibault writes ("[Xen-devel] [PATCH] ioemu: improve colordepth
> negociation"):
> > +static vga_draw_line_func *vga_draw_line_table[NB_DEPTHS *
> > VGA_DRAW_LINE_NB] = {
> > + vga_draw_line2_8,
> > + vga_draw_line2_16,
> > + vga_draw_line2_16,
> > + vga_draw_line2_32,
> > + vga_draw_line2_32,
> ...
> > -static vga_draw_line_func *vga_draw_line_table[NB_DEPTHS *
> > VGA_DRAW_LINE_NB] = {
> > - vga_draw_line2_8,
> > - vga_draw_line2_16,
> > - vga_draw_line2_16,
> > - vga_draw_line2_32,
> > - vga_draw_line2_32,
>
> Could I suggest that it would be a good idea to avoid enormous code
> rearrangements like this in ioemu ? That's only going to make the
> ongoing merge situation with qemu worse.
>
> If you were moving this up the file so that you could refer to it
> later, you could provide a forward declaration.
I was wondering about it indeed. I'll provide another patch.
Samuel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home