WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] more profiling

To: "Santos, Jose Renato G" <joserenato.santos@xxxxxx>, "Andy Grover" <andy.grover@xxxxxxxxxx>
Subject: RE: [Xen-devel] more profiling
From: "James Harper" <james.harper@xxxxxxxxxxxxxxxx>
Date: Tue, 4 Mar 2008 10:02:51 +1100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 03 Mar 2008 15:03:23 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C7B67062D31B9E459128006BAAD0DC3D0753DC1AF1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AEC6C66638C05B468B556EA548C1A77D0131AF31@trantor> <AEC6C66638C05B468B556EA548C1A77D0131AF34@trantor> <C7B67062D31B9E459128006BAAD0DC3D0753CEC544@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <AEC6C66638C05B468B556EA548C1A77D0131AF35@trantor> <C7B67062D31B9E459128006BAAD0DC3D0753D4CB61@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <AEC6C66638C05B468B556EA548C1A77D0131AF5D@trantor> <C7B67062D31B9E459128006BAAD0DC3D0753DC1AF1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ach6wj+maafveOiCSzitY54bCV1UyQAFngGQAAfOF9AACjpIIABt/jjgAAH8D7AAIJCP4AAHtrxQ
Thread-topic: [Xen-devel] more profiling
> > Under windows, it is the code that gets the next free ref
> > that is protected by spinlocks. I believe that if we only get
> > the ref once, but then reuse that ref over and over, then
> > we'd get a lot better performace.
> >
> 
>   Yes. Avoiding the spinlock should improve performance. Definetely,
it
> should be a win on the RX path. But is it worth in the TX path, if you
now
> have to copy the packet? Do you have experimental data showing that
> copying is better than the spinlock? I don't have much experience with
> Windows but I think this would be very surprising...

Looking at the profiling data that I have collected, the copy operation
(max 1500 bytes copy, probably around 200-300 on average) does appear to
consume less CPU resources than the acquire spinlock operation. The
other thing to consider is that Windows seems to give us 2-3 separate
pages of data per packet, one containing the header, another containing
the next header, and one containing the layer 3 data. This would be
three get grant entry operations.

However, if I can avoid the spinlock-per-grant-entry, and also avoid
copying, then things will be even better!

Btw, with 'request-rx-copy = 1', does that mean that the backend still
makes copies of the data to give to us?

James

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>