This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] limit ACPIID to APICID reset to AMD machines

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] limit ACPIID to APICID reset to AMD machines
From: Mark Langsdorf <mark.langsdorf@xxxxxxx>
Date: Fri, 29 Feb 2008 13:02:31 -0600
Delivery-date: Fri, 29 Feb 2008 11:02:20 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6 (enterprise 20070904.708012)
Testing by Red Hat show that changeset:0034d9389130 causes regressions
on Intel machines that don't use APIC ID lifting but that do have a
strange ACPI to APIC numbering.

Modify the patch so that it only applies to AMD machines.

-Mark Langsdorf
Operating System Research Center

Signed-off-by: Mark Langsdorf <mark.langsdorf@xxxxxxx>

diff -r 49ffe9ef67d4 drivers/xen/core/smpboot.c
--- a/drivers/xen/core/smpboot.c        Fri Feb 29 10:29:13 2008 +0000
+++ b/drivers/xen/core/smpboot.c        Fri Feb 29 12:54:47 2008 -0600
@@ -276,7 +276,8 @@ void __init smp_prepare_cpus(unsigned in
        cpu_2_logical_apicid[0] = 0;
        x86_cpu_to_apicid[0] = 0;
-       set_x86_acpiid_to_apicid(0, 0);
+       if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
+               set_x86_acpiid_to_apicid(0, 0);
        current_thread_info()->cpu = 0;
@@ -325,7 +326,8 @@ void __init smp_prepare_cpus(unsigned in
                cpu_2_logical_apicid[cpu] = cpu;
                x86_cpu_to_apicid[cpu] = cpu;
-               set_x86_acpiid_to_apicid(cpu, cpu);
+               if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
+                       set_x86_acpiid_to_apicid(cpu, cpu);
                idle = fork_idle(cpu);
                if (IS_ERR(idle))

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>