This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [patch 0/5] kexec: Remove xen/common/compat/kexec.c

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [patch 0/5] kexec: Remove xen/common/compat/kexec.c
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Fri, 29 Feb 2008 17:41:24 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 29 Feb 2008 00:41:52 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3ED6611.1480C%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080229062854.370669317@xxxxxxxxxxxx> <C3ED6611.1480C%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
On Fri, Feb 29, 2008 at 07:34:41AM +0000, Keir Fraser wrote:
> On 29/2/08 06:28, "Simon Horman" <horms@xxxxxxxxxxxx> wrote:
> > as discussed briefly on xen-devel, the method of defining compat
> > functions for kexec involves a two-phase build of xen/common/kexec.c,
> > hinging around the inclusion of xen/common/compat/kexec.c.
> > 
> > This series of patches systematically removes any need for
> > xen/common/compat/kexec.c and then removes xen/common/compat/kexec.c
> > itself.
> Thanks, I'll take a look. It looks like it's not really a reduction in code
> size, but is rather less likely to make the readers brain bleed!

More thought would be needed if lines of code reduction is desired,
though I think that the size of the output of the compile might
be slightly smaller.

It does however seem to make things less bleed prone :-)

I noticed a slight problem with compiling without CONFIG_COMPAT
after lunch. I have posted my update to the relevant patch.


Xen-devel mailing list