This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [amd iommu] [patch 1/2]Add APCI table support for AMD IO

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [amd iommu] [patch 1/2]Add APCI table support for AMD IOMMU
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Thu, 28 Feb 2008 18:10:10 +0000
Cc: Wei Wang2 <wei.wang2@xxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxx>
Delivery-date: Thu, 28 Feb 2008 10:10:38 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1204203101.8542.55.camel@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1204203101.8542.55.camel@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6 (enterprise 0.20070907.709405)
Some comments below.

+void __init dump_acpi_table_header(struct acpi_table_header *table)

I think this can be static?

Throughout this file you've used slightly Linux-y coding style.  Is this 
intentional?  In particular, the brackets around if expressions aren't spaced 
out from the expression as they usually are under Xen and in one place you've 
missed a newline before a {.  If you're trying to keep the coding style in 
sync to minimise the diff with upstream sources then I think that's quite 
reasonable (although I think we usually keep tabbed indenting if importing 
from upstream Linux).

Keir will probably let you know if he thinks the formatting is important or 
check the code in otherwise, so don't let me worry you too much!

Other than these few comments, your code largely made my patch checking suite 
happy, so nice work ;-)


Push Me Pull You - Distributed SCM tool (http://www.cl.cam.ac.uk/~maw48/pmpu/)

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>