This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix c/s 17104

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix c/s 17104
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 28 Feb 2008 16:22:04 +0000
Cc: "Li, Haicheng" <haicheng.li@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 28 Feb 2008 08:23:39 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200802281712.32307.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ach6Jg3dTEI6JOYZEdygygAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Fix c/s 17104
User-agent: Microsoft-Entourage/
Yes, Intel's most recently mentioned bug (1180: low-res and low-colour WinXP
display) is also due to the mmio changes. At least it goes away when I
revert changesets 17105, 17104, 17102, 17100, 17098, 17090, in that order.

 -- Keir

On 28/2/08 16:12, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> On Monday 25 February 2008 10:03:18 Keir Fraser wrote:
>> Nice one. I didn't have a good coding afternoon on Friday. :-(
>> In general the mmio (and other) emulation changes have had very little
>> testing on AMD, so please do test and let me know if anything else has
>> broken.
> Yes, there are MMIO problems. We tracked them down to changeset 17090.
> Christoph
>>  -- Keir
>> On 25/2/08 08:22, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
>>> Hi Keir,
>>> Changeset 17104 does not look correct to me.
>>> svm_set_interrupt_shadow() seems to be a copy & paste bug, because
>>> the intr_shadow parameter is unused.
>>> I think, what you intended to do is the attached patch.
>>> That's all what I found so far just from reading the diff - but there may
>>> be more. Please double-check.
>>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>