WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] FW: [PATCH][UPDATE]Remove lock on guest table walk

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Subject: Re: [Xen-devel] FW: [PATCH][UPDATE]Remove lock on guest table walk
From: "Gianluca Guida" <gianluca.guida@xxxxxxxxxxxxx>
Date: Thu, 28 Feb 2008 13:28:14 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 28 Feb 2008 05:29:26 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <D470B4E54465E3469E2ABBC5AFAC390F024D8FD5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <D470B4E54465E3469E2ABBC5AFAC390F024D8FD1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <yga63we70mt.wl%gianluca.guida@xxxxxxxxxxxxx> <D470B4E54465E3469E2ABBC5AFAC390F024D8FD5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.7 Emacs/22.1 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI)
At Mon, 25 Feb 2008 09:37:42 +0800,
Tian, Kevin wrote:
> Here it is. Thanks again for pointing it out. 

One last thing. At the moment we're auditing the tables and the guest
walk when we're not sure that the walk itself is consistent or
not. Inline patch fixes this.

Thanks,
Gianl.


diff -r 993a7e1d224d xen/arch/x86/mm/shadow/multi.c
--- a/xen/arch/x86/mm/shadow/multi.c    Thu Feb 28 13:21:54 2008 +0000
+++ b/xen/arch/x86/mm/shadow/multi.c    Thu Feb 28 13:24:11 2008 +0000
@@ -2952,8 +2952,6 @@ static int sh_page_fault(struct vcpu *v,
 #endif /* (SHADOW_OPTIMIZATIONS & SHOPT_VIRTUAL_TLB) */
 
     shadow_lock(d);
-    shadow_audit_tables(v);
-    sh_audit_gw(v, &gw);
 
     if ( gw_remove_write_accesses(v, va, &gw) )
     {
@@ -2971,6 +2969,9 @@ static int sh_page_fault(struct vcpu *v,
         shadow_unlock(d);
         return EXCRET_fault_fixed;
     }
+
+    shadow_audit_tables(v);
+    sh_audit_gw(v, &gw);
 
     /* Make sure there is enough free shadow memory to build a chain of
      * shadow tables. (We never allocate a top-level shadow on this path,

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>