WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] ioemu block device extent checks

Daniel P. Berrange writes ("Re: [Xen-devel] [PATCH] ioemu block device extent 
checks"):
> I don't think this is correct - it allows a -ve  size / nb_sectors
> value when autoextenable is set, and allows out of bounds reads.

That's fine because it's only called like that as a the parent block
driver.  Perhaps a different name would have been better.

Out of bounds reads have to be permitted because the block size in the
header may remain un-updated, so reads of newly-cloned blocks may
fail.

> I sent a patch to qemu-devel yuesterday which also uses the auto-extend
> flag, but has separate checks for read vs writes. When doing a write that
> would extend the device it increases the total_sectors count so that the
> subsequent reads can be validated to be within the written bounds.

Well, that seems like makework to me but fine if upstream accept it.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel