This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] linux: adjust Solarflare module_param() permissi

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] linux: adjust Solarflare module_param() permissions
From: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>
Date: Thu, 21 Feb 2008 09:54:51 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 21 Feb 2008 01:55:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47BD4BDE.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <47BD4BDE.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2008-02-21 at 09:01 +0000, Jan Beulich wrote:
> Using permissions with bit 1 set (i.e. 0666) is prohibited on module
> parameters on 2.6.20+. Presumably it was never meant to permit writes
> by everyone?

Correct, sorry - due my being lazy when first writing the code and
forgetting to do it properly later.

This is a good change, but the patch will conflict with the earlier fix
to prevent the module parameter names clashing when statically compiled.
Attached is a re-spin that should apply cleanly to the staging tree.

Signed-off-by Kieran Mansley <kmansley@xxxxxxxxxxxxxx>

diff -r 0569bf9338ba drivers/xen/sfc_netback/accel.c
--- a/drivers/xen/sfc_netback/accel.c
+++ b/drivers/xen/sfc_netback/accel.c
@@ -72,7 +72,7 @@ static struct notifier_block netback_acc
 unsigned sfc_netback_max_pages = NETBACK_ACCEL_DEFAULT_MAX_BUF_PAGES;
-module_param_named(max_pages, sfc_netback_max_pages, uint, 0666);
+module_param_named(max_pages, sfc_netback_max_pages, uint, 0644);
                 "The number of buffer pages to enforce on each guest");
diff -r 0569bf9338ba drivers/xen/sfc_netfront/accel_netfront.c
--- a/drivers/xen/sfc_netfront/accel_netfront.c
+++ b/drivers/xen/sfc_netfront/accel_netfront.c
@@ -235,11 +235,11 @@ struct netfront_accel_hooks accel_hooks 
 unsigned sfc_netfront_max_pages = NETFRONT_ACCEL_DEFAULT_BUF_PAGES;
-module_param_named (max_pages, sfc_netfront_max_pages, uint, 0666);
+module_param_named (max_pages, sfc_netfront_max_pages, uint, 0644);
 MODULE_PARM_DESC(max_pages, "Number of buffer pages to request");
 unsigned sfc_netfront_buffer_split = 2;
-module_param_named (buffer_split, sfc_netfront_buffer_split, uint,
+module_param_named (buffer_split, sfc_netfront_buffer_split, uint,
                 "Fraction of buffers to use for TX, rest for RX");

Attachment: param_permissions
Description: Text Data

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>