This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] compat_mmuext_op - continuation code is wrong

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] compat_mmuext_op - continuation code is wrong
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Wed, 20 Feb 2008 19:12:03 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 20 Feb 2008 11:12:53 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3E21F1A.1CBB5%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080220172115.GA7180@xxxxxxxxxxxxxxxxxxxxxxx> <C3E21F1A.1CBB5%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Feb 20, 2008 at 06:16:58PM +0000, Keir Fraser wrote:

> > But we never initialised the guest's "pdone" at any point. So we can
> > copy in an uninit stack value into 'done', add 'i' to it, then copy it
> > back out. On Solaris, we assert that the success count == what we passed
> > in, so this breaks Solaris 32/64
> > 
> > I'm running on 3.1 with a couple of fixes from unstable to make it work
> > at all. The below patch works for us but I'm not confident in its
> > correctness.
> Better to remove the preempt check altogether, as it's already done
> (correctly) in do_mmuext_op(). That's what I'll check in.

That's what we initially tested, and works for us. Thanks.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>