This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] Minor fix to the fast emulation patch.

To: "Gianluca Guida" <gianluca.guida@xxxxxxxxxxxxx>, <tim.deegan@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Minor fix to the fast emulation patch.
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Tue, 19 Feb 2008 08:49:41 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 18 Feb 2008 16:51:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <yga7ih16b8z.wl%gianluca.guida@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <yga7ih16b8z.wl%gianluca.guida@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Achyjnr1HlXAeaTFSBSp/1UOE+UOegAAj5rA
Thread-topic: [Xen-devel] [PATCH] Minor fix to the fast emulation patch.
Oh, good spot. My overlook when moving unlock before that snippet.
It doesn't occur in our stress test, and my rough feeling is to observe
such warning once per months. Thanks for finding it. :-)


>From: Gianluca Guida
>Sent: 2008年2月19日 8:28
>The fast emulation path patch introduced a bug when we have an event
>injection during a write to a pagetable: after removing shadows we
>still jump to the done label, releasing the lock even if we aren't
>grabbing it.
>Inline patch fixes this.
>Signed-off-by: Gianluca Guida <gianluca.guida@xxxxxxxxxxxxx>
>diff -r 8848d9e07584 xen/arch/x86/mm/shadow/multi.c
>--- a/xen/arch/x86/mm/shadow/multi.c   Mon Feb 18 21:26:57 2008 +0000
>+++ b/xen/arch/x86/mm/shadow/multi.c   Tue Feb 19 00:20:00 2008 +0000
>@@ -3020,7 +3020,7 @@ static int sh_page_fault(struct vcpu *v,
>                      "injection: cr2=%#lx, mfn=%#lx\n", 
>                      va, mfn_x(gmfn));
>             sh_remove_shadows(v, gmfn, 0 /* thorough */, 1 /* 
>must succeed */);
>-            goto done;
>+            return EXCRET_fault_fixed;
>         }
>     }

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>