WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entrie

To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entries
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 18 Feb 2008 13:44:32 +0000
Delivery-date: Mon, 18 Feb 2008 05:45:12 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200802181332.51143.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchyNGPmoqLDmt4nEdykwQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entries
User-agent: Microsoft-Entourage/11.3.6.070618
On 18/2/08 12:32, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> adjust_guest_l3e() adds (_PAGE_USER|_PAGE_RW) to the entry, and then
> get_page_from_l3e() checks that _PAGE_USER or _PAGE_RW are not present
> for PAE guests.  get_page_from_l3e() will always fail at this point
> for PAE guests.
> 
> Attached patch fixes this. This bug has been uncovered with NetBSD 32bit PAE
> guests.

It breaks the fast update path, and also all mod_lN_entry() functions should
probably be reorganised for consistency. I'll make these changes and apply
it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel